Chart: add OpenSearch remote logging options #45082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherinternational
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
topherinternational
force-pushed
the
opensearch-chart-option
branch
3 times, most recently
from
df90bba to
5435776
Compare
topherinternational
force-pushed
the
opensearch-chart-option
branch
from
5435776 to
ed3e71c
Compare
|
LGTM! |
topherinternational
force-pushed
the
opensearch-chart-option
branch
from
ed3e71c to
be6d56f
Compare
eladkal
approved these changes
Jan 3, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* add OpenSearch remote logging options
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
* add OpenSearch remote logging options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change duplicates the existing elasticsearch configurations to support the new OpenSearch remote logging option added in #41799.
In addition to adding the
opensearchblock invalues.yaml, it also adds a disambiguation check to prevent users from enabling both Elasticsearch and openSearch remote logging, as Airflow does not support using both at the same time.Finally, a suite of tests is added to test the existing Elasticsearch configuration options as well as the new OpenSearch options. A few existing tests have been moved to put all of the ES/OS/remote logging behaviors under a single test module.